-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow using initials as Avatar
placeholder
#375
feat: allow using initials as Avatar
placeholder
#375
Conversation
Add new prop, `placeholderInitials`, to the `Avatar` component. String passed in this prop will be displayed as `Avatar`'s placeholder, if image is not provided. Refs: themesberg#357
Update the docs with newly added feature, that allows usage of initials as a placeholder for `Avatar` component themesberg#357
Codecov ReportBase: 98.61% // Head: 98.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 98.61% 98.59% -0.02%
==========================================
Files 89 89
Lines 4116 4138 +22
Branches 375 377 +2
==========================================
+ Hits 4059 4080 +21
- Misses 57 58 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
@iamargentum I guess that now the CI is just saying that we need to put some unit test to cover the new logic. :) |
okay! |
Refs: #357
Description
This PR adds a new prop,
placeholderInitials
, to theAvatar
component. String passed in this prop will be displayed asAvatar
's placeholder, if image is not provided.Fixes #357
Type of change
Breaking changes
No breaking changes
How Has This Been Tested?
Just checked visually
Checklist:
Screencast.from.10-10-22.01.57.39.AM.IST.webm