Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds footer component #59

Merged
merged 34 commits into from
May 5, 2022
Merged

feat: adds footer component #59

merged 34 commits into from
May 5, 2022

Conversation

mouracamila
Copy link
Collaborator

/closes #8

@tulup-conner
Copy link
Collaborator

Hi there, are you still working on this? If there's more to do I would be happy to finish it up.

@mouracamila
Copy link
Collaborator Author

Hi there, are you still working on this? If there's more to do I would be happy to finish it up.

Yes, I'm.

@mouracamila mouracamila marked this pull request as ready for review April 27, 2022 11:47
@mouracamila mouracamila requested review from rluders and bacali95 April 27, 2022 11:47
@mouracamila mouracamila requested a review from rluders May 3, 2022 09:47
@mouracamila mouracamila self-assigned this May 3, 2022
tulup-conner
tulup-conner approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can cut down even more of the boilerplate for users but this is really solid

src/lib/components/Footer/FooterCopyright.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterIcon.tsx Outdated Show resolved Hide resolved
rluders
rluders requested changes May 3, 2022
View reviewed changes
src/lib/components/Footer/FooterLink.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterIcon.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterCopyright.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterBrand.tsx Outdated Show resolved Hide resolved
@mouracamila mouracamila requested a review from rluders May 4, 2022 12:46
@mouracamila
Copy link
Collaborator Author

I don't add the footer heading, because it wants to be created separately and utilised in other places..

rluders
rluders requested changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, all the struct looks nice. I just left few comments, you can mark them as "resolved" as you progress with the changes.

src/lib/components/Footer/Footer.stories.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterCopyright.tsx Outdated Show resolved Hide resolved
src/docs/pages/FooterPage.tsx Outdated Show resolved Hide resolved
src/docs/pages/FooterPage.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/Footer.stories.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/Footer.stories.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/Footer.stories.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterCopyright.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterIcon.tsx Outdated Show resolved Hide resolved
tulup-conner
tulup-conner requested changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a11y notes

src/lib/components/Footer/FooterBrand.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterIcon.tsx Outdated Show resolved Hide resolved
src/lib/components/Footer/FooterLink.tsx Outdated Show resolved Hide resolved
@mouracamila mouracamila requested a review from rluders May 5, 2022 14:14
@rluders rluders merged commit 7799f15 into themesberg:main May 5, 2022
@rluders
Copy link
Collaborator

rluders commented May 5, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulup-conner tulup-conner tulup-conner requested changes

@bacali95 bacali95 Awaiting requested review from bacali95

@rluders rluders Awaiting requested review from rluders

Assignees

@mouracamila mouracamila

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build Footer component
3 participants
@mouracamila @tulup-conner @rluders