-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary dependencies (babel, lodash) #4
Comments
I'll consider removing lodash dependency since I don't depend on it much. But babel/ecmascript: nope, if that means I can't write the package code in ES6+ any more. If there is a way to use ES6+ and distribute only transpiled/ES5 code to users of this package, then that'd be alright. If you'd like to investigate, that'd be helpful. Also, actually we also have a jquery dependency here that I failed to add. I'm not sure if I can remove that... (see https://github.com/themeteorites/blaze-magic-events/blob/master/events.js#L10 for why it's needed) Any ideas for how to solve that differently are welcome. |
I know two packages with this feature w/o jQuery: |
Hey @comerc! Thanks for the links! I've checked out only the last one so far, and I like what I see! I'm fairly confident now that I'll get rid of the jQuery dependency next time I'll work on this project. Regarding the other dependencies: For lodash I'll have to consider the options. As I see it, I can: For babel this is what needs to be done:
What I definitely will not do because it would be a silly thing is go back to pre-ES6 JS code. ES6+ is the way to go, even if it should have some impact on depending projects -- which, again, there should not be. Anyone who cares so super much that this would be an issue is free to just either fork this repo or inline their own version of this code into their project. :) Just as an fyi -- I'm not really working a whole lot with Meteor in my current projects, so it might be some more weeks or so until I'll feel the need to work on this. PRs welcome, but if none come I should get around to this eventually. In any case thanks for opening this issue and posting helpful stuff, keep it going if there's more! Cheers |
+1 !!!! |
Please-please-please! :) It is not true way for package.
The text was updated successfully, but these errors were encountered: