"Or" in conditional logics

[hellor0bot]

Is it possible to add "or" operator in the conditional logics?

See the syntax from WP_Query:

    'tax_query' => array(
        'relation' => 'OR',
        array(
            'taxonomy' => 'movie_genre',
            'field'    => 'slug',
            'terms'    => array( 'action', 'comedy' ),
        ),
        array(
            'taxonomy' => 'actor',
            'field'    => 'term_id',
            'terms'    => array( 103, 115, 206 ),
            'operator' => 'NOT IN',
        ),
    ),

Please correct me if I'm wrong, but there's no thing like relation in Kirki now and it accepts only AND by default.

[rahulv3a]

If you are talking about required, Kirki uses AND operator.

But there is a workaround to use OR operator, see #769.

[hellor0bot]

The workaround is quite dirty though. For example I have select 1 and select 2, both have 10 options each, with this workaround I would have to specify 18 (!) conditions instead of two.

[rahulv3a]

I agree. I hope they address this in the future versions.

[aristath]

There are plans to do that in a future release, just not yet.

The syntax that will probably be used will be like this:

'required' => array(
    array(
        array(
        ),
        // OR
        array(
        ),
    ),
    // AND
    array(
    ),
),

Right now there are simply more important issues to deal with so this will have to wait for a while...

Marking as a feature request 👍

[hellor0bot]

Thanks, @aristath!

[aristath]

This is now implemented in the develop branch, I'd really appreciate it if you guys could test it.

Example:

'active_callback' => array(
    array(
        array(
            'setting'  => 'setting_1',
            'operator' => '==',
            'value'    => true,
        ),
        array(
            'setting'  => 'setting_2',
            'operator' => '==',
            'value'    => true,
        ),
    ),
    array(
        'setting'  => 'setting_3',
        'operator' => '==',
        'value'    => true,
    ),
),

The above can be translated like this:
( ( if setting_1 == true OR setting_2 == true ) AND setting_3 == true )

[aristath]

In other words, active_callback is an array.
each item in that array is evaluated using AND.
However, if that item is an array of requirements, then these are evaluated using OR.

[guillaumemolter]

Ahah...I was ready it and it wasn't making sence. Better now :-)

[aristath]

LOL yeah, there was a typo that I edited. ;)

[aristath]

@guillaumemolter do you perhaps have any ideas on how to make the syntax easier to understand?
I just found this structure pretty versatile... This way we're not limited to either AND or OR and we can combine them.

[guillaumemolter]

Hmmm...I think it's pretty clear this way. Personally I may have implemented the WP_Meta_Query syntax but not because it is easier or easier to understand but simply because I would assume it's the "WordPress way" to do it. In other words I think it is great like that so unless someones complain leave it like that :-).

[rahulv3a]

Just tested this, works like a charm 👍

[hellor0bot]

Thanks, it's working. But the syntax really bothers me. Don't think it's flexible enough.

I suppose it must be AND inside the item array and OR between items.

Just the opposite:

( ( if setting_1 == true AND setting_2 == true ) OR setting_3 == true )

Otherwise we can't group conditions:

( ( if setting_1 == true AND setting_2 == true ) OR ( if setting_3 == false AND setting_4 == false ) )

[aristath]

I suppose it must be AND inside the item array and OR between items.

I agree, but unfortunately we can't do that because it would break things for everyone that was using it before the change.
Maintaining backwards-compatibility is a bitch, I know...

[hellor0bot]

Sometimes breaking changes are unavoidable. That's why they're breaking ;)

Anyway, I think it's better to change it now, before Kirki gains even more users. However it's your product and I can't really complain. It's so great and saved me a lot of time, really. Thanks a lot, really.