Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json incorrect, breaks with incompatible versions #62

Open
noerw opened this issue Jul 26, 2018 · 1 comment
Open

package.json incorrect, breaks with incompatible versions #62

noerw opened this issue Jul 26, 2018 · 1 comment

Comments

@noerw
Copy link

noerw commented Jul 26, 2018

I can't use this module, because it does not declare its dependencies correctly (all in the devDependencies field):

rxjs, @angular/core, possibly more should go into dependencies.

This breaks, when you have different versions in your project, e.g. rxjs v6:

./node_modules/angular2-lightbox/lightbox-event.service.js
Module not found: Error: Can't resolve 'rxjs/Subject' in '/home/norwin/src/eumetsat-new-pn/pn-ng6/node_modules/angular2-lightbox'
@themyth92
Copy link
Owner

To support rxjs v6, could you please use this module instead https://github.com/themyth92/ngx-lightbox. Current module will not support v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants