Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NICE and NICE.jl give different results #3

Open
PaulWAyers opened this issue Apr 10, 2023 · 3 comments
Open

NICE and NICE.jl give different results #3

PaulWAyers opened this issue Apr 10, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@PaulWAyers
Copy link
Member

Based on Hasan's tests, NICE and NICE.jl give different results.

We should figure out what's going on. His presentation is Thursday, and I doubt I'll have time to look at it before then. @msricher do you think you could see what's off? @mmg870630 might be helpful too.

Marco, this is a net-event kinetic-Monte-Carlo code we've been working on in the group.

@PaulWAyers PaulWAyers added the bug Something isn't working label Apr 10, 2023
@msricher
Copy link
Collaborator

msricher commented Apr 17, 2023

I'd tend to trust the Julia version over the Fortran version, which interfaces with Python and might no longer work properly? They're just ports of the same code otherwise. (Just speculation)

@PaulWAyers
Copy link
Member Author

True. But we need to know why they are different too. I thought it was just that the equilibrium constants were defined in inverse (one used forward, and one used reverse) equilibrium constants. But I'm not sure it is that simple.

@Charlie-1-3
Copy link

Different languages and libraries might handle numerical precision differently. Small differences in numerical precision can accumulate over time and lead to divergent results.
Also, both implementations involve randomness in selecting reactions (kmc_select_reaction and nekmc_select_reaction).
Ensure that both implementations use the same random number generation method and seed to obtain consistent results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants