Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when checking int vs np.int64 #89

Open
kimt33 opened this issue Mar 31, 2019 · 0 comments
Open

Errors when checking int vs np.int64 #89

kimt33 opened this issue Mar 31, 2019 · 0 comments

Comments

@kimt33
Copy link
Collaborator

kimt33 commented Mar 31, 2019

Since the type of each parameter is thoroughly checked, the check for the parameter type raises an error when numpy array is used. Turns out np.int64 is not a child of int, so we cannot just check that the input is an integer. I've hacked in a fix (also check if the parameter is an instance of np.int64), but there should be a better way to handle these inputs.

This problem also occurs with float and np.float64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant