Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v17.0 builds but is not listed in pgenv versions #81

Closed
sathishmanohar opened this issue Oct 12, 2024 · 12 comments
Closed

v17.0 builds but is not listed in pgenv versions #81

sathishmanohar opened this issue Oct 12, 2024 · 12 comments

Comments

@sathishmanohar
Copy link

sathishmanohar commented Oct 12, 2024

pgenv use 17.0
PostgreSQL 17.0 not installed; installed versions:
  *   11.10     pgsql-11.10
      16.4      pgsql-16.4
pgenv versions
  *   11.10     pgsql-11.10
      16.4      pgsql-16.4
ls .pgenv
bin  config  patch  pgsql  pgsql-11.10  pgsql-16.4  src  LICENSE.md  README.md
ls ~/.pgenv/src
postgresql-11.10  postgresql-16.4  postgresql-17.0  postgresql-11.10.tar.bz2  postgresql-16.4.tar.bz2  postgresql-17.0.tar.bz2

I'm on Arch Linux BTW

@fluca1978
Copy link
Collaborator

Seems it is not installed at all, since you don't have pgsql-17.0 in your PGENV_ROOT.
However, it does list 17 when installed:

% pgenv versions
      16.0      pgsql-16.0
      16.1      pgsql-16.1
      16.2      pgsql-16.2
  *   17.0      pgsql-17.0

@fljdin
Copy link

fljdin commented Oct 15, 2024

I'm facing the same issue with 17.0

$ pgenv build 17.0
...
make[1]: Leaving directory '/var/lib/pgenv/src/postgresql-17.0/src'

$ pgenv versions
Using PGENV_ROOT /var/lib/pgenv
      15.4      pgsql-15.4
  *   15.6      pgsql-15.6
      16.0      pgsql-16.0

With 16.4, the ending line looks different:

$ pgenv build 16.4
...
make[1]: Leaving directory '/var/lib/pgenv/src/postgresql-16.4/contrib'
pgenv configuration written to file /var/lib/pgenv/config/default.conf
PostgreSQL 16.4 built

The make install stuff seems to be skipped on 17.0 build step

@fluca1978
Copy link
Collaborator

I'm facing the same issue with 17.0

$ pgenv build 17.0
...
make[1]: Leaving directory '/var/lib/pgenv/src/postgresql-17.0/src'

Are there errors reported in the output?
What version of pgenv are you running?

@theory
Copy link
Owner

theory commented Oct 15, 2024

Might the build be failing due to #79?

@sathishmanohar
Copy link
Author

sathishmanohar commented Oct 15, 2024

make[3]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/contrib/spi'
cp ../../../contrib/spi/refint.so refint.so
cp ../../../contrib/spi/autoinc.so autoinc.so
make[2]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/test/regress'
/usr/bin/make -C test/isolation all
make[2]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/test/isolation'
/usr/bin/make -C ../../../src/interfaces/libpq all
/usr/bin/make -C ../../../src/port all
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -I. -I. -I../../../src/interfaces/libpq -I./../regress -I../../../src/include  -D_GNU_SOURCE   -c -o isolationtester.o isolationtester.c
make[3]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/interfaces/libpq'
/usr/bin/make -C ../../../src/port all
make[3]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/port'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/port'
/usr/bin/make -C ../../../src/common all
make[4]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/port'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/port'
/usr/bin/make -C ../../../src/common all
make[3]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/common'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/common'
/usr/bin/bison -Wno-deprecated  -d -o specparse.c specparse.y
make[4]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/common'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/common'
make[3]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/interfaces/libpq'
/usr/bin/flex   -o'specscanner.c' specscanner.l
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -I. -I. -I../../../src/interfaces/libpq -I./../regress -I../../../src/include  -D_GNU_SOURCE   -c -o isolation_main.o isolation_main.c
/usr/bin/make -C ../../../src/test/regress pg_regress.o
make[3]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/test/regress'
/usr/bin/make -C ../../../src/port all
make[4]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/port'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/port'
/usr/bin/make -C ../../../src/common all
make[4]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/common'
make[4]: Nothing to be done for 'all'.
make[4]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/common'
make[3]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/test/regress'
touch specparse.h
rm -f pg_regress.o && ln -s ../../../src/test/regress/pg_regress.o .
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -I. -I. -I../../../src/interfaces/libpq -I./../regress -I../../../src/include  -D_GNU_SOURCE   -c -o specparse.o specparse.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -I. -I. -I../../../src/interfaces/libpq -I./../regress -I../../../src/include  -D_GNU_SOURCE   -c -o specscanner.o specscanner.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 isolation_main.o pg_regress.o -L../../../src/interfaces/libpq -lpq -L../../../src/port -L../../../src/common   -Wl,--as-needed -Wl,-rpath,'/home/user/.pgenv/pgsql-17.0/lib',--enable-new-dtags  -lpgcommon -lpgport -lz -lreadline -lm  -o pg_isolation_regress
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 isolationtester.o specparse.o specscanner.o -L../../../src/interfaces/libpq -lpq -L../../../src/port -L../../../src/common   -Wl,--as-needed -Wl,-rpath,'/home/user/.pgenv/pgsql-17.0/lib',--enable-new-dtags  -lpgcommon -lpgport -lz -lreadline -lm  -o isolationtester
make[2]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/test/isolation'
/usr/bin/make -C test/perl all
make[2]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/src/test/perl'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src/test/perl'
make[1]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/src'

This is how the build ends for me. I don't see an error

@theory
Copy link
Owner

theory commented Oct 15, 2024

Hrm. so $HOME/.pgenv/pgsql-17.0 exists?

@sathishmanohar
Copy link
Author

sathishmanohar commented Oct 15, 2024

No.

ls .pgenv
bin   config   patch   pgsql   pgsql-11.10   pgsql-16.4   src   LICENSE.md   README.md
ls .pgenv/src/                                                                   
postgresql-11.10   postgresql-16.4   postgresql-17.0   postgresql-11.10.tar.bz2   postgresql-16.4.tar.bz2   postgresql-17.0.tar.bz2

@theory
Copy link
Owner

theory commented Oct 15, 2024

Then the install did not finish; no idea why there are no errors. Can you try the patch in #80?

@sathishmanohar
Copy link
Author

sathishmanohar commented Oct 15, 2024

Replaced ~/.pgenv/bin/pgenv with the pgenv file from the branch you referred to. Now the psql 17.0 is built successfully.

/usr/bin/make -C vacuumlo install
make[2]: Entering directory '/home/user/.pgenv/src/postgresql-17.0/contrib/vacuumlo'
/usr/bin/mkdir -p '/home/user/.pgenv/pgsql-17.0/bin'
/usr/bin/install -c  vacuumlo '/home/user/.pgenv/pgsql-17.0/bin'
make[2]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/contrib/vacuumlo'
make[1]: Leaving directory '/home/user/.pgenv/src/postgresql-17.0/contrib'
pgenv configuration written to file /home/user/.pgenv/config/17.0.conf
PostgreSQL 17.0 built
pgenv versions
      11.10     pgsql-11.10
  *   16.4      pgsql-16.4
      17.0      pgsql-17.0

After pgenv use 17.0

psql --version
psql (PostgreSQL) 17.0

@theory
Copy link
Owner

theory commented Oct 15, 2024

Yeah, it was the documentation issue, then. Closing as a dupe of #79, thanks!

@theory theory closed this as completed Oct 15, 2024
@theory
Copy link
Owner

theory commented Oct 16, 2024

FYI: #80 has been merged to fix this issue, and related in v1.3.8.

@fluca1978
Copy link
Collaborator

I've marked v1.3.8 as latest, since github was reporting 1.3.7 as the latest to download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants