Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple default scopes #42

Closed
cziegenberg opened this issue May 9, 2013 · 2 comments
Closed

Multiple default scopes #42

cziegenberg opened this issue May 9, 2013 · 2 comments
Milestone

Comments

@cziegenberg
Copy link
Contributor

The idea of default scopes is good in some situations, but if you really use scopes, you have multiple scopes that are assigned as default.

At the moment only one scope can be set as default. It would be possible to set an array, because the parameters are not checked, but the scripts calling this method expect an string at the moment.

@alexbilbie
Copy link
Contributor

Good suggestion, I'll add it in the next release

@cziegenberg
Copy link
Contributor Author

I think the check you added for #43

if ($this->authServer->scopeParamRequired() === true && $this->authServer->getDefaultScope() === null && count($scopes) === 0) {

needs to be changed, because you can also have an enpty string or empty array or better: check the value in "setDefaultScope" and keep the null if empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants