Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily rewards for ZZZ #201

Closed
TheraNinjaCat opened this issue Jul 4, 2024 · 5 comments · Fixed by #200
Closed

Add daily rewards for ZZZ #201

TheraNinjaCat opened this issue Jul 4, 2024 · 5 comments · Fixed by #200

Comments

@TheraNinjaCat
Copy link

A cursory look at the network tab during ZZZ daily reward claim suggests that there's nothing significantly different from the Genshin or StarRail ones.

@seriaati
Copy link
Collaborator

seriaati commented Jul 4, 2024

See #200

@seriaati seriaati linked a pull request Jul 5, 2024 that will close this issue
7 tasks
@seriaati
Copy link
Collaborator

seriaati commented Jul 5, 2024

You can try it out now by installing the dev branch version of genshin.py

@TheraNinjaCat
Copy link
Author

Are you absolutely sure you've checked out the dev branch and are actually running that version of the library? I just tested the dev branch with a simple

import genshin
client = genshin.Client()
client.set_cookies(...)
await client.claim_daily_reward(game=genshin.Game.ZZZ)

and it worked perfectly fine when I had checked out and run pip install . on the dev branch. I ran the same code after checking out and running pip install . on the master branch however and I got the exact error you've experienced (RuntimeError: URL does not support ZZZ game for OVERSEAS region.). My account is in the Asia region for what it's worth.

I can't speak to the code redeem, I'm not familiar in the slightest with that code.

@rennerdo30
Copy link

Are you absolutely sure you've checked out the dev branch and are actually running that version of the library? I just tested the dev branch with a simple

import genshin
client = genshin.Client()
client.set_cookies(...)
await client.claim_daily_reward(game=genshin.Game.ZZZ)

and it worked perfectly fine when I had checked out and run pip install . on the dev branch. I ran the same code after checking out and running pip install . on the master branch however and I got the exact error you've experienced (RuntimeError: URL does not support ZZZ game for OVERSEAS region.). My account is in the Asia region for what it's worth.

I can't speak to the code redeem, I'm not familiar in the slightest with that code.

Thanks for taking your time to answer. I've already deleted my comment, since I realized, that pip did not update the package, since it was already installed. This was an error on my side, hence I already deleted my comment.

using this command resolved the issue for me:

pip install  --upgrade --force-reinstall git+https://github.com/thesadru/genshin.py@dev

@seriaati
Copy link
Collaborator

Dev changes are now merged into master, you can use the master branch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants