Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript errors being thrown for missing graphql client #45

Closed
1 of 5 tasks
thescientist13 opened this issue Sep 7, 2021 · 2 comments · Fixed by #47
Closed
1 of 5 tasks

JavaScript errors being thrown for missing graphql client #45

thescientist13 opened this issue Sep 7, 2021 · 2 comments · Fixed by #47
Assignees
Labels
0.4.1 bug Something isn't working
Milestone

Comments

@thescientist13
Copy link
Owner

Type of Change

  • New Feature Request
  • Documentation
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

After upgrading to 0.4.0 without the #2 , the templates are still referencing the old usage?
Screen Shot 2021-09-07 at 9 38 44 AM

Details

Looks like package.json is fine, but everything the templates are still the old version?
Screen Shot 2021-09-07 at 9 39 02 AM
Screen Shot 2021-09-07 at 9 39 10 AM

@thescientist13 thescientist13 added the bug Something isn't working label Sep 7, 2021
@thescientist13 thescientist13 added this to the MVP milestone Sep 7, 2021
@thescientist13 thescientist13 self-assigned this Sep 7, 2021
@thescientist13
Copy link
Owner Author

Ah, it looks like I may have a mis-understanding of the npm prepublish lifecycle? Looks like it doesn't actually do anything before publishing? I guess I should use prepublishOnly instead?

Ugh... so awkward, lol.

@thescientist13
Copy link
Owner Author

Perfect, works as expected now

% npm publish

> greenwood-starter-presentation@0.4.1 prepublishOnly
> rm -rf dist/ && mkdir dist/ && yarn dist

yarn run v1.22.5
$ rsync -rv --exclude 'pages/' src/ dist
building file list ... done
assets/
assets/background.jpg
components/
components/iframe-key-capture.js
components/link-target.js
components/presenter-mode.js
components/slide-list.js
components/slide-viewer.js
layouts/
layouts/index.html
layouts/page.html
layouts/theme-center-content.html
layouts/theme-outline.html
layouts/theme-statement.html
layouts/theme-title.html
layouts/theme-top-title-image-left.html
layouts/theme-top-title.html
styles/
styles/main.css
styles/theme.css

sent 69053 bytes  received 396 bytes  138898.00 bytes/sec
total size is 67766  speedup is 0.98
✨  Done in 0.09s.
npm notice 
npm notice 📦  greenwood-starter-presentation@0.4.1
npm notice === Tarball Contents === 
npm notice 9.4kB  README.md                                   
npm notice 49.1kB dist/assets/background.jpg                  
npm notice 93B    dist/components/iframe-key-capture.js       
npm notice 305B   dist/components/link-target.js              
npm notice 2.3kB  dist/components/presenter-mode.js           
npm notice 2.7kB  dist/components/slide-list.js               
npm notice 633B   dist/components/slide-viewer.js             
npm notice 2.8kB  dist/layouts/index.html                     
npm notice 570B   dist/layouts/page.html                      
npm notice 1.2kB  dist/layouts/theme-center-content.html      
npm notice 702B   dist/layouts/theme-outline.html             
npm notice 1.2kB  dist/layouts/theme-statement.html           
npm notice 2.3kB  dist/layouts/theme-title.html               
npm notice 1.5kB  dist/layouts/theme-top-title-image-left.html
npm notice 1.4kB  dist/layouts/theme-top-title.html           
npm notice 555B   dist/styles/main.css                        
npm notice 534B   dist/styles/theme.css                       
npm notice 492B   index.js                                    
npm notice 1.7kB  package.json                                
npm notice === Tarball Details === 
npm notice name:          greenwood-starter-presentation          
npm notice version:       0.4.1                                   
npm notice filename:      greenwood-starter-presentation-0.4.1.tgz
npm notice package size:  43.9 kB                                 
npm notice unpacked size: 79.4 kB                                 
npm notice shasum:        7f43f53cd00bee20ecba48df47b2c85f04ef0d52
npm notice integrity:     sha512-agGKvrqb3AYiT[...]8gWBCYLb3G8HQ==
npm notice total files:   19                                      
npm notice 
This operation requires a one-time password.
Enter OTP: 070837
+ greenwood-starter-presentation@0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4.1 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant