Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ICU Support #9

Open
c-thiel opened this issue Oct 31, 2024 · 3 comments
Open

feat: ICU Support #9

c-thiel opened this issue Oct 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@c-thiel
Copy link

c-thiel commented Oct 31, 2024

@brianheineman I have one more (and believe last) feature I am missing: Support for ICU.
We are using case insensitive collations defined as:

    CREATE COLLATION case_insensitive (
      provider = icu,
      locale = 'und-u-ks-level2',
      deterministic = false
    )

Which currently raises:

Error: DriverError(IoError(error returned from database: ICU is not supported in this build

Caused by:
   ICU is not supported in this build

Would it be possible to add ICU-support for the binaries?

@c-thiel
Copy link
Author

c-thiel commented Oct 31, 2024

I see it is explicitly disabled here:

@brianheineman
Copy link
Contributor

Hello @c-thiel, thank you for the request. The ICU API appears to be versioned such that creating a build for one version (7.2) will be incompatible with another (7.4). In order to add ICU support to all the builds, there is some additional work that needs to be done to postgresql_embedded to detect the type/version of a linux distribution so that the appropriate binary could be pulled from this repository. This repository would then need to be updated to support the main distributions/versions. I think this would be the least disruptive way to add ICU support for all users. I think this would be a useful feature to add but I cannot commit to if/when I will have the time to look into it.

@c-thiel
Copy link
Author

c-thiel commented Nov 2, 2024

Thank you @brianheineman for trying - I appreciate the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants