Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream: fix ops (comments from Mark Brown) #525

Closed
plbossart opened this issue Jan 10, 2019 · 2 comments
Closed

Upstream: fix ops (comments from Mark Brown) #525

plbossart opened this issue Jan 10, 2019 · 2 comments
Assignees
Labels
upstream blocker Mandatory for upstream

Comments

@plbossart
Copy link
Member

> +/* control */
> +static inline int snd_sof_dsp_run(struct snd_sof_dev *sdev)
> +{
> +	if (sdev->ops->run)
> +		return sdev->ops->run(sdev);
> +
> +	return 0;
> +}

Do we really want to return 0 for all these ops if they're not
implemented?  For some that seems sensible but there's others where it
seems like the caller might want to know they got ignored and an error
code like -ENOTSUPP might be better.

Need to scrub all ops routines and mark which ones are required and which ones are optional, and add -ENOTSUPP if relevant?

@plbossart plbossart added the upstream blocker Mandatory for upstream label Jan 10, 2019
@ranj063 ranj063 self-assigned this Jan 14, 2019
@ranj063
Copy link
Collaborator

ranj063 commented Jan 14, 2019

#539 fixes this issue

@plbossart
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream blocker Mandatory for upstream
Projects
None yet
Development

No branches or pull requests

2 participants