Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagram in system memory not rendering properly #342

Open
cujomalainey opened this issue Apr 20, 2021 · 5 comments
Open

diagram in system memory not rendering properly #342

cujomalainey opened this issue Apr 20, 2021 · 5 comments

Comments

@cujomalainey
Copy link
Contributor

you can see parts of the images clipped https://thesofproject.github.io/latest/developer_guides/firmware/mem-mgmt.html#system-zone

@lgirdwood
Copy link
Member

@intelkevinputnam are you able to help here ? Looks like the image size is set too small in the html ?

@lgirdwood
Copy link
Member

@deb-intel fyi - not sure if this sort of stuff is also in your scope.

@intelkevinputnam
Copy link
Collaborator

@lgirdwood I took a quick look, and it looks like a problem with the .svg itself as it is reporting its size as width: 178pt and height: 288pt. I don't have time to dig in today, but can look at it later this week.

@lgirdwood
Copy link
Member

@intelkevinputnam thanks, please also check git blame as the author may be able to regenerate the image with the correct size. Alternatively if it's generated as part of documentation build then it may be a tooling issue ?

@intelkevinputnam
Copy link
Collaborator

@lgirdwood I dug a little deeper and it looks like it is a problem with the version of graphviz used to generate the website. It is not a problem with either Sphinx or the .dot defintion file as far as I can tell. The svg that sphinx generates on my machine looks fine using version 2.40.1-2 of graphviz. It looks like version 2.42.2-3build2 is used in the GitHub action that builds the site and generates the faulty image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants