From 76e650e56598110422624961992ef09bcec645c7 Mon Sep 17 00:00:00 2001 From: Laurentiu Mihalcea Date: Thu, 12 Sep 2024 16:06:59 +0300 Subject: [PATCH] .github/zephyr: switch to python 3.10 on windows Zephyr commit b3b8360f3993 ("west: runners: Add `west rtt` command with pyocd implementation") adds some functionality to the west commands making use of the pipe ("|") operator for function return type hinting. As per PEP 604 [1], this operator can be used for writing union types starting from python 3.10. Since the SOF windows builds use python 3.8 this leads to the CI failing. To fix this, switch to using python 3.10. This is not a problem for Linux CI jobs as they already use python 3.10. The following is a snippet of a failed windows CI job regarding this: File "D:\a\sof\sof\workspace\zephyr\scripts/west_commands\runners\core.py", line 780, in ZephyrBinaryRunner def get_rtt_address(self) -> int | None: TypeError: unsupported operand type(s) for |: 'type' and 'NoneType' [1]: https://peps.python.org/pep-0604/ Signed-off-by: Laurentiu Mihalcea --- .github/workflows/zephyr.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/zephyr.yml b/.github/workflows/zephyr.yml index 99698a9a6b17..c98d0bcda859 100644 --- a/.github/workflows/zephyr.yml +++ b/.github/workflows/zephyr.yml @@ -305,7 +305,7 @@ jobs: - name: Setup Python uses: actions/setup-python@v5 with: - python-version: '3.8' + python-version: '3.10' - name: West install run: pip3 install west @@ -329,7 +329,7 @@ jobs: uses: actions/setup-python@v5 id: cache-python with: - python-version: '3.8' + python-version: '3.10' cache: 'pip' cache-dependency-path: workspace/zephyr/scripts/requirements.txt