Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test cert generation script for postgresql #1163

Merged
merged 2 commits into from
May 25, 2017

Conversation

ashfall
Copy link
Contributor

@ashfall ashfall commented May 16, 2017

This can be used to regenerate testing certs for postgres db connections.

Depends on #1160

Signed-off-by: Ashwini Oruganti <ashwini.oruganti@gmail.com>
@ashfall
Copy link
Contributor Author

ashfall commented May 16, 2017

This addresses @cyli's comment from #1160 (comment)


# Postgresql keys for testing server/client auth

# TODO: test if cfssl is installed, if not, cleanly exit with a message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used something like this before:

command -v cfssljson  >/dev/null 2>&1 || { 
    echo >&2 "Installing cfssl tools"; go get -u github.com/cloudflare/cfssl/cmd/...;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you kindly. Will update! :)

Signed-off-by: Ashwini Oruganti <ashwini.oruganti@gmail.com>
@cyli
Copy link
Contributor

cyli commented May 23, 2017

Thanks for working on this! LGTM with the caveat that we might want to create the dir database first with mkdir -p in the script, just create it and check it into git, or alternately first merge #1160 before merging this PR.

@ashfall
Copy link
Contributor Author

ashfall commented May 23, 2017

@cyli Thanks! I am going with getting #1160 merged first, unless there's a strong preference for the former?

@cyli
Copy link
Contributor

cyli commented May 23, 2017

Nope that works for me!

@riyazdf
Copy link
Contributor

riyazdf commented May 25, 2017

jenkins, test this please

Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM pending green on jenkins tests, and also we should open an issue to migrate the other cert generation bits in regnerateTestingCerts.sh to also use cfssl - it's a little odd to only use cfssl for certain certs and openssl for others

@ashfall
Copy link
Contributor Author

ashfall commented May 25, 2017

@riyazdf Thanks! Filed #1168

@cyli
Copy link
Contributor

cyli commented May 25, 2017

There were no previous changes to that file, and seem to be no conflicts, so merging anyway :) Thanks @ashfall!

@cyli cyli merged commit 51ff192 into notaryproject:master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants