Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up default log level, key import/export logs #1179

Merged
merged 2 commits into from
Jun 8, 2017

Conversation

riyazdf
Copy link
Contributor

@riyazdf riyazdf commented Jun 5, 2017

  • makes warn the default log level on notary CLI
  • increases the -v log level from error to info
  • bumps up key import/export failure logs from info to warn

cc @cyc115 @ecordell

Closes #1162, #1178

Ex: here's what an offline notary list looks like now if there's a cache with a valid timestamp:

🐳 $ ./notary -s https://notary.docker.io list docker.io/library/alpine
ERRO[0000] could not reach https://notary.docker.io: Get https://notary.docker.io/v2/: dial tcp: lookup notary.docker.io on [::1]:53: read udp [::1]:56941->[::1]:53: read: connection refused
WARN[0000] Error while downloading remote metadata, using cached timestamp - this might not be the latest version available remotely
NAME               DIGEST                                                              SIZE (BYTES)    ROLE
----               ------                                                              ------------    ----
2.6                9ace551613070689a12857d62c30ef0daa9a376107ec0fff0e34786cedb3399b    528             targets
2.7                9f08005dff552038f0ad2f46b8e65ff3d25641747d3912e3ea8da6785046561a    1374            targets
<..snip..>

…ging

Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ashfall ashfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyli
Copy link
Contributor

cyli commented Jun 8, 2017

LGTM

@riyazdf riyazdf merged commit 7c74907 into notaryproject:master Jun 8, 2017
@riyazdf riyazdf deleted the import-key-warning branch June 8, 2017 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants