Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.10.1 #1332

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Update to Go 1.10.1 #1332

merged 2 commits into from
Apr 9, 2018

Conversation

justincormack
Copy link
Contributor

@justincormack justincormack commented Apr 7, 2018

Keep up with the Go releases. Linter found some additional errors (oops!). Also update some test dependencies as they were failing on Darwin with Go 1.10.

fix #1322

Keep up with the Go releases. Linter found some additional errors.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
This fixes test issues with Go 1.10 on Darwin.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
@justincormack justincormack changed the title Update to Go 1.10 Update to Go 1.10.1 Apr 7, 2018
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riyazdf riyazdf merged commit a57c5a7 into notaryproject:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.10: memory.go:227: Sprintf format %d has arg changeID of wrong type string
3 participants