-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tar.gz release does not contain LICENSE #1160
Comments
Wow. I have no idea why but setuptools3 seems to include all files in project root directory -- this seems to not be documented. The documentation says we should add files into MANIFEST.in if we want to distribute but not install (which seems to be what most projects do with LICENSE files). |
Yikes. I thought I had produced the last two release tarballs with Python 3's setuptools3... We should update the docs/RELEASE.md to strongly recommend using python3 and add LICENSE to I can make those changes today. |
I think at least being explicit about LICENSE* in MANIFEST.in makes sense. I don't think I understand how these different results happen yet: distutils is the one that actually does the sdist building and I can't see anything in the dosc (https://docs.python.org/3/distutils/sourcedist.html#specifying-the-files-to-distribute) or the code that would imply that what I saw with python3 is intentional: no mention of including all files in root by default as an example. |
Documenting for posterity: the differences between py3 and py2 were the results of having The original issue tar.gz release does not contain LICENSE is still valid. |
This seems to be a common way to handle license files. Also, vendoring tool fails to handle tuf without a LICENSE file. Fixes theupdateframework#1160 Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
This seems to be a common way to handle license files. Also, vendoring tool fails to handle tuf without a LICENSE file. Fixes theupdateframework#1160 Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
This seems to be a common way to handle license files. Also, vendoring tool fails to handle tuf without a LICENSE file. Fixes theupdateframework#1160 Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
Description of issue or feature request:
Release tarballs (like tuf-0.14.0.tar.gz) do not contain a LICENSE file
This prevents vendoring tuf using the
vendoring
tool: I could patch the license in but unfortunately the license file check is done on unpatched sourcespython3 setup.py sdist
produces a tarball with the LICENSE file (and many other files that are not in our release tarball) -- what's this about?The text was updated successfully, but these errors were encountered: