Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment for step2 #879

Closed
wants to merge 1 commit into from

Conversation

lixuefeng2
Copy link
Contributor

No description provided.

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @lixuefeng2! I appreciate the suggestion, but I wonder if it is really necessary. To me the tutorial reads as one train of thought, where it is implicit that the snippets are based on each other. I vote for not merging. @awwad, what do you think?

If we do, please consider my comments below.

@@ -41,9 +41,10 @@ to the client in the `tufclient` directory.

We'll create a target file that will later be delivered as an update to clients.
Metadata about that file will be created and signed, and added to the
repository's metadata.
repository's metadata.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove trailing whitespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukpueh done.
I tried to test TUF in my project. I encountered this problem(I changed to data directory and I thought TUF shall remember the repo folder). It may be a trap for beginners like me:). So in my opinion it's necessary. You are expert of it, but not everyone is expert. People may think it's hard to use or it has bugs..


```Bash
# be in the same directory as step 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add this here, we should add a similar first line to the snippets below for consistency. What about # Continued from above?

Signed-off-by: lixuefeng (Cloud) <li.xuefeng@h3c.com>
@lukpueh
Copy link
Member

lukpueh commented Sep 17, 2019

Closing due to inactivity and incompleteness. #808 (comment), has a similar request:

  • Let's make all snippets # Continuing from the previous section . . ..

@lukpueh lukpueh closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants