Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken document links #378

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Fix broken document links #378

merged 6 commits into from
Mar 26, 2024

Conversation

dmint789
Copy link
Member

@dmint789 dmint789 commented Mar 23, 2024 •
edited
Loading

Fixes #376

  • Add wcadoc{} shortcut that inserts a link to documents.worldcubeassociation.org
  • Fix all broken links related to the move of documents to the documents subdomain
  • Fix broken link from CoE to Spirit motion
  • Fix broken link from Disciplinary Committee motion to Suspensions and Other Sanctions motion

Deni added 2 commits January 24, 2024 20:50
Add image source files. Update timers to reflect the newest (gen 5) v…
32ede64 
…ersion. Remake the scorecard image in the competitor tutorial from scratch and include scrambler signatures in it. Add missing translation update for the Portuguese competitor guide. Rename some image files for consistency.
Add wcadoc{} shortcut. Fix broken links.
de5c923
@dmint789 dmint789 requested a review from a team as a code owner March 23, 2024 08:55
@dmint789 dmint789 requested a review from a team March 23, 2024 08:55
@dmint789 dmint789 requested review from a team as code owners March 23, 2024 08:55
@dmint789
Copy link
Member Author

@thewca/software-team please approve, this is urgent.

Deni added 3 commits March 23, 2024 10:01
Fix spirit link in CoE
5656484
Revert "Add image source files. Update timers to reflect the newest (…
610e44d 
…gen 5) version. Remake the scorecard image in the competitor tutorial from scratch and include scrambler signatures in it. Add missing translation update for the Portuguese competitor guide. Rename some image files for consistency."

This reverts commit 32ede64.
Fix broken link in Disciplinary Committee motion. Clean up regs link …
83cf505 
…in Regulations and Guidelines motion.
@dmint789
Copy link
Member Author

I have downloaded the build and made sure that every single affected link works correctly now.

@dmint789 dmint789 changed the title Fix links Fix broken document links Mar 23, 2024
nsilvestri
nsilvestri approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@nsilvestri nsilvestri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lnzainn
lnzainn approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@lnzainn lnzainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Epride Epride merged commit 1ab8f63 into thewca:master Mar 26, 2024
1 check passed
@dmint789 dmint789 deleted the fix-links branch May 20, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnzainn lnzainn lnzainn approved these changes

@dunkOnIT dunkOnIT dunkOnIT approved these changes

@Epride Epride Epride approved these changes

@nsilvestri nsilvestri nsilvestri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links for some documents
5 participants
@dmint789 @nsilvestri @Epride @dunkOnIT @lnzainn