Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-runtime incorrectly listed as a dev dependency #9

Open
EthanZeigler opened this issue Oct 24, 2022 · 2 comments
Open

babel-runtime incorrectly listed as a dev dependency #9

EthanZeigler opened this issue Oct 24, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@EthanZeigler
Copy link

See github-tools/github-release-notes#109 for the same issue.

Babel-runtime is supposed to be defined as a production dependency, not a dev dependency. This causes errors where babel runtime imports fail when bundling for production and development such as below

✘ [ERROR] Could not resolve "@babel/runtime/helpers/slicedToArray"

    node_modules/@thinknimble/tn-models/lib/models/model.js:14:53:
      14 │ var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
@whusterj
Copy link
Member

Hi @EthanZeigler - really appreciate the report. Makes sense to me. I would want to take a minute to look into this before making a change, since we use this library in a few places and I haven't seen this issue before.

cc: @paribaker in case you beat me to it.

@whusterj whusterj added the bug Something isn't working label Oct 25, 2022
@EthanZeigler
Copy link
Author

I'd guess it's already required somewhere else in your dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants