Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Scroll the Modal When Window Height is Low #4314

Open
ninpeng opened this issue Aug 29, 2024 · 2 comments
Open

Unable to Scroll the Modal When Window Height is Low #4314

ninpeng opened this issue Aug 29, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working as intended in a provided reproduction. React SDK Involves changes to the React SDK.

Comments

@ninpeng
Copy link

ninpeng commented Aug 29, 2024

Explanation

When the screen height is low, such as in landscape mode on mobile, the modal cannot be scrolled, making it cannot to close or proceed.

Attach Image

image

@gregfromstl gregfromstl self-assigned this Aug 29, 2024
@gregfromstl gregfromstl added Bug Something isn't working as intended in a provided reproduction. React SDK Involves changes to the React SDK. labels Aug 29, 2024
@adamiller1014
Copy link

adamiller1014 commented Sep 12, 2024

I can fix this issue like this

-thirdweb\src\react\web\ui\ConnectWallet\constants.ts
Add below line
export const modalMaxHeightCompact = "100vh";

-thirdweb\src\react\web\ui\ConnectWallet\Modal\ConnectEmbed.tsx
And Edit this line from
height: modalSize === "compact" ? "auto" : wideModalMaxHeight, overflow: "hidden",
To
height: modalSize === "compact" ? modalMaxHeightCompact : wideModalMaxHeight, overflow: "auto",
Result looks like this
1
2

@gregfromstl
Copy link
Member

Hey @adamiller1014 feel free to open a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as intended in a provided reproduction. React SDK Involves changes to the React SDK.
Projects
None yet
Development

No branches or pull requests

3 participants