Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimizations #234

Closed
thmarx opened this issue Sep 8, 2024 · 2 comments
Closed

Performance optimizations #234

thmarx opened this issue Sep 8, 2024 · 2 comments
Milestone

Comments

@thmarx
Copy link
Collaborator

thmarx commented Sep 8, 2024

  • Reuse js context for request and theme
  • think about using a object pool for js context
@thmarx thmarx added this to the 5.3.0 milestone Sep 8, 2024
thmarx pushed a commit that referenced this issue Sep 8, 2024
thmarx pushed a commit that referenced this issue Sep 8, 2024
thmarx pushed a commit that referenced this issue Sep 8, 2024
@thmarx
Copy link
Collaborator Author

thmarx commented Sep 9, 2024

simple performance tests done with ab, the command is executed twice, first for warmup, second for metric.
ab -n 1000 -c 10 http://localhost:1010/

result without pool

Connection Times (ms)

min mean[+/-sd] median max
Connect 0 0 [0.5] 0 2
Processing 6 12 [6.6] 11 124
Waiting 5 12 [6.6] 11 124
Total 6 13 [6.6] 11 124

result after enableing pool

min mean[+/-sd] median max
Connect 0 0 [0.4] 0 4
Processing 2 7 [6.0] 4 25
Waiting 2 7 [6.0] 3 25
Total 2 7 [6.0] 4 26

thmarx pushed a commit that referenced this issue Sep 9, 2024
@thmarx
Copy link
Collaborator Author

thmarx commented Sep 11, 2024

for the first this should be enough,

maybe we should look into the following points:

but open new issues for that.

@thmarx thmarx closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant