Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Theme] error if different template engines configured #76

Closed
thmarx opened this issue Nov 15, 2023 · 0 comments · Fixed by #78
Closed

[Theme] error if different template engines configured #76

thmarx opened this issue Nov 15, 2023 · 0 comments · Fixed by #78
Labels
bug Something isn't working
Milestone
2.9.0

Comments

@thmarx
Copy link
Collaborator

thmarx commented Nov 15, 2023

Current version takes the configured template engine from site properties. This can/will cause trouble with the engine used for theme if they don't match. cms should throw an error on startup, if the parameters do not match.
@thmarx thmarx added the bug Something isn't working label Nov 15, 2023
@thmarx thmarx added this to the 2.9.0 milestone Nov 15, 2023
thmarx pushed a commit that referenced this issue Nov 17, 2023
#76 throw error if template engines does not match
9b34ea4
@thmarx thmarx linked a pull request Nov 17, 2023 that will close this issue
#76 throw error if template engines does not match #78
Merged
thmarx added a commit that referenced this issue Nov 17, 2023
@thmarx
#76 throw error if template engines does not match (#78)
9c0a91d 
* #76 throw error if template engines does not match

* next release version

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

#76 throw error if template engines does not match CondationCMS/cms-server
1 participant
@thmarx