Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Added new a parameter OutputPath for Compress-7Zip #60

Merged
merged 11 commits into from
Jun 6, 2020

Conversation

iRebbok
Copy link
Contributor

@iRebbok iRebbok commented May 27, 2020

Content:

  • Added the System.Management.Automation dependency to the repository.
  • Added the OutputPath parameter for Compress-7Zip.

Why does this make sense?

  • Native support for a different archive output path allows you to call a script in a third-party folder and not process the archive output path.

P.S: I need this for my CI, I call the script from the repository folder and want to not process the output file of the archive in addition.

@iRebbok
Copy link
Contributor Author

iRebbok commented May 29, 2020

@thoemmi Can you take a look at this PR?

@thoemmi
Copy link
Owner

thoemmi commented May 29, 2020

@iRebbok I don't have access to my machine at the moment. I'm afraid you have to wait till next week before I will review your PR.

@iRebbok
Copy link
Contributor Author

iRebbok commented May 29, 2020

@thoemmi Well, I will also review my code, I want to make sure that when you specify a non-existent folder, it will also work fine, thank you!

@thoemmi thoemmi merged commit baa5105 into thoemmi:master Jun 6, 2020
@thoemmi
Copy link
Owner

thoemmi commented Jun 6, 2020

Merged in master. @iRebbok Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants