Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray class group map could be a bit more intelligent #1289

Open
thofma opened this issue Nov 21, 2023 · 2 comments
Open

Ray class group map could be a bit more intelligent #1289

thofma opened this issue Nov 21, 2023 · 2 comments

Comments

@thofma
Copy link
Owner

thofma commented Nov 21, 2023

We can map factored ideals to ray class groups, but the individual factors need to be coprime to the modulus:

function disclog(J::FacElem{NfOrdIdl, NfOrdIdlSet})
@vprintln :RayFacElem 1 "Disc log of element $J"
a = id(X)
for (f, k) in J
a += k*disclog(f)
end
return a
end

I think we can do better. Here is a quick example to reproduce the issue.

julia> K, a = rationals_as_number_field();

julia> OK = maximal_order(K);

julia> M = 12*OK;

julia> R, f = ray_class_group(M);

julia> I = FacElem([9*OK, 3*OK, 5 * OK], ZZRingElem[1, -2, 1]);

julia> Hecke.assertions(true);

julia> f\(numerator(evaluate(I)))
Element of R with components [0 1]

julia> f\(I)
ERROR: AssertionError: $(Expr(:escape, :(is_coprime(J, m))))
Stacktrace:
@thofma
Copy link
Owner Author

thofma commented Nov 21, 2023

The caller should call simplify!. Not sure we want to do it in this function.

@thofma thofma closed this as completed Nov 21, 2023
@thofma thofma reopened this Nov 21, 2023
@thofma
Copy link
Owner Author

thofma commented Nov 21, 2023

We are checking is_coprime anyway, so we should just adjust it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant