Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for multiple exporters #2535

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hoangnv-bkhn
Copy link
Contributor

@hoangnv-bkhn hoangnv-bkhn commented Oct 17, 2024

Description

  • Support for configuring multiple exporters simultaneously
  • The way it was resolved:
    Each data exporter will be initialized with a separate schedule to operate independently of each other.
  • How to test the change:
    Refer: Example

Closes issue(s)

Resolve #2505

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit b64acf6
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6711209cc8846600092d00e5

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.78%. Comparing base (7e35bc7) to head (1c17a54).

Files with missing lines Patch % Lines
cmd/relayproxy/service/gofeatureflag.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2535      +/-   ##
==========================================
+ Coverage   85.84%   86.78%   +0.94%     
==========================================
  Files         100      100              
  Lines        3554     3595      +41     
==========================================
+ Hits         3051     3120      +69     
+ Misses        378      347      -31     
- Partials      125      128       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoangnv-bkhn hoangnv-bkhn marked this pull request as draft October 17, 2024 10:29
@hoangnv-bkhn hoangnv-bkhn force-pushed the feat/support-for-multiple-exporters branch from 1235b8a to b64acf6 Compare October 17, 2024 14:35
Copy link

sonarcloud bot commented Oct 17, 2024

@hoangnv-bkhn hoangnv-bkhn marked this pull request as ready for review October 17, 2024 14:40
@@ -107,8 +107,7 @@ jobs:
const staleIssues = await github.paginate(github.rest.issues.listForRepo, {
owner, repo,
state: 'open',
labels: staleLabel,
assignee: '*'
Copy link
Contributor Author

@hoangnv-bkhn hoangnv-bkhn Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified this to handle the case where the assignee unassigns themselves (while the Assigned label remains).
This case was found in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Support for multiple exporters
2 participants