fix wrong destination domain suffix with '.net' #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: pingparsing doesn't handle destination parsing with '.net' domain correctly
Result and steps to appear:
Expected result:
The reason is that
strip()
in Python will remove all characters in function argument._parse_destination
function tries to removeping statistics ---
, but it removest
in.net
, which is not expected.Add a quick fix for that issue, hope it helps, thanks.