Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused tag sensor from devices not really using it #151

Closed
4 tasks done
thomluther opened this issue Oct 30, 2024 · 1 comment
Closed
4 tasks done

Remove unused tag sensor from devices not really using it #151

thomluther opened this issue Oct 30, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@thomluther
Copy link
Owner

System Health details

None

Integration version

2.1.0

Checklist

  • I have enabled debug logging for my installation.
  • I have filled out the issue template to the best of my ability.
  • This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
  • This issue is not a duplicate issue of any previous issues..

Describe the issue

All devices got a Tag sensor that may show the tag if the device supports tagging like smart plugs do.
Devices not supporting tagging will show an empty sensor.

The cloud Api introduced this additional field for all devices and the Api library as well as the integration picked it up.

Reproduction steps

upgrade to 2.1.0 to see the tag entity for every device

Debug logs

None

Diagnostics dump

No response

@thomluther thomluther added the bug Something isn't working label Oct 30, 2024
@thomluther thomluther added this to the 2.2.0 milestone Oct 30, 2024
@thomluther
Copy link
Owner Author

The tag sensor will now be added only if the tag field really has a value set.
Empty strings will be ignored.
Note: There won't be translations for the tags, since it is unknown which kind of tags are supported or may be added in future.

There was also a new tag category implemented with 2.1.0 to exclude the tag field in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant