feat(slatetodom): add alwaysEncodeBreakingEntities option #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-pribilinskiy
pushed a commit
to cloudbeds/slate-serializers
that referenced
this pull request
May 3, 2023
github-actions bot
pushed a commit
to cloudbeds/slate-serializers
that referenced
this pull request
May 3, 2023
# [1.1.0](v1.0.1...v1.1.0) (2023-05-03) ### Bug Fixes * lint and format ([thompsonsj#58](https://github.com/cloudbeds/slate-serializers/issues/58)) ([9ab446d](9ab446d)) ### Features * **slatetodom:** add encodeBreakingEntities option ([thompsonsj#57](https://github.com/cloudbeds/slate-serializers/issues/57)) ([e9040fa](e9040fa))
hygorzorak
pushed a commit
to cloudbeds/slate-serializers
that referenced
this pull request
Oct 16, 2023
* lint and format ([thompsonsj#58](https://github.com/cloudbeds/slate-serializers/issues/58)) ([9ab446d](9ab446d)) * **slatetodom:** add encodeBreakingEntities option ([thompsonsj#57](https://github.com/cloudbeds/slate-serializers/issues/57)) ([e9040fa](e9040fa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
alwaysEncodeBreakingEntitiesoption toslateToDom.Details
<,>and&only.alwaysEncodeBreakingEntitiesonly takes effect ifencodeEntitiesisfalse. This is becauseencodeEntitiesencodes breaking entities anyway.Background
In CrowdIn, encoded entities are supported. Translators can hover over encoded entities to see the character used.
However, it would be much more convenient to send
utf8characters as they are. This makes translations easier to manage, and avoids situations where translations receive a warning because an encoded entity is not included in the translation.