Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormBuilder] Take a look for react performance #4

Open
MangelMaxime opened this issue Nov 8, 2019 · 3 comments
Open

[FormBuilder] Take a look for react performance #4

MangelMaxime opened this issue Nov 8, 2019 · 3 comments
Labels

Comments

@MangelMaxime
Copy link
Contributor

Issue by MangelMaxime
Wednesday Nov 28, 2018 at 10:08 GMT
Originally opened as MangelMaxime/Thoth#90


I think the library "BasicFields" should by default offer optimized react experience.

@MangelMaxime
Copy link
Contributor Author

Comment by fergusmeiklejohn
Thursday Nov 29, 2018 at 03:19 GMT


I think BasicFields should offer a "withDefaults" experience. Most apps might only ever need BasicFields.

@MangelMaxime
Copy link
Contributor Author

Comment by MangelMaxime
Thursday Nov 29, 2018 at 06:55 GMT


What do you mean by "withDefaults" ?

@MangelMaxime
Copy link
Contributor Author

Comment by fergusmeiklejohn
Thursday Nov 29, 2018 at 08:10 GMT


Ideally we would have the most common types of field and they would come with sensible defaults including validation as standard. I was wondering about using validator.js for this:
https://github.com/chriso/validator.js
https://www.npmjs.com/package/@types/validator
Like you know how in html a Form at it's most basic is:

  <form>
    <input name="name" placeholder="Name" />
    <input name="email" placeholder="Email" type="email" />
    <input type="submit">
  </form>

I wonder if we could make BasicFields (maybe in Fulma?) as close as possible to this sort of simple experience, but of course with all the power of F# and this library behind the simple interface

Apologies this has little to with React, more to do with "optimized experience"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant