-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With few repo moved to pyproject.toml the sphinx docs generation needs modification #98
Comments
Looks like build_sphinx is deprecated anyway, yet there is not a standard remplacement. Python packaging, I guess 😭 |
More details: I see two options going forward:
@harshad16 @codificat any prefs ? |
we can try the first method, and use Line 44 in b3ac82f
to PYTHONPATH=. pipenv run sphinx-build docs/source/ build/html it would fix the nepthys issues. though setting version value https://github.com/thoth-station/python/blob/29050e8b2848f228caccd44cd6828c0077bde13f/docs/source/conf.py#L43 would be a problem. |
I think sphinx-pyproject might help with that, if we can pass the version from the pyproject.toml file.
|
@Gkrumbach07 @harshad16 |
I don't think so. Chromatic only is used to evaluate UI components. It does not handle or use any docs gen. However when generating the docs, we will want them to be styled in the same way as the website. I looked into using Gatsby to generate the docs, but that didn't seem feasible. However may be a way to add styling over the generated docs. |
As we might move to the gatsby-themed website, our requirements to generate HTML files might not be needed anymore. This would make further feature development on nepthys low priority. we should fix the current bug, by moving components to pyproject style and making change to accommodate sphix build from pyproject. |
Is your feature request related to a problem? Please describe.
We build sphinx docs using the setup.py build_sphinx command, however as we have moved a few repositories to use pyproject.toml . we have to accommodate the new changes, so we can build sphinx docs using pyproject.toml.
Additional context
The text was updated successfully, but these errors were encountered: