Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the permitted_attributes may need pass current action #2352

Closed
jubilee2 opened this issue Apr 12, 2023 · 2 comments · Fixed by #2356
Closed

the permitted_attributes may need pass current action #2352

jubilee2 opened this issue Apr 12, 2023 · 2 comments · Fixed by #2356

Comments

@jubilee2
Copy link
Contributor

administrate/lib/generators/administrate/dashboard/templates/controller.rb.erb

Line 39 in 062ea9f

# permit(dashboard.permitted_attributes).

the permitted_attributes may need pass current action to support "FORM_ATTRIBUTES_NEW" and "FORM_ATTRIBUTES_EDIT".

otherwise only go through "FORM_ATTRIBUTES" whatever edit or new action.
@pablobm
Copy link
Collaborator

pablobm commented Apr 13, 2023

Uh, I think you are right. Interestingly, permitted_attributes calls form_attributes, which does accept an action.

Would you be able to provide a PR?

@jubilee2
Copy link
Contributor Author

related #2066

@jubilee2 jubilee2 mentioned this issue Apr 17, 2023
Merged
@pablobm pablobm mentioned this issue Apr 19, 2023
Closed
@mattwr18 mattwr18 mentioned this issue Sep 9, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make permitted_attributes support action jubilee2/administrate
2 participants
@pablobm @jubilee2