Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the search function #2362

Open
pablobm opened this issue Apr 20, 2023 · 0 comments
Open

Redesign the search function #2362

pablobm opened this issue Apr 20, 2023 · 0 comments
Labels
epic search finding things through our models

Comments

@pablobm
Copy link
Collaborator

pablobm commented Apr 20, 2023

We have a few open issues regarding the search function, marked with search finding things through our models :

The common themes I'm seeing here are:

  • Better detection of DB structure, supporting STI, edge cases with associations, aliased fields...
  • Provide better hooks and documentation about customization.

I think it's time to rethink how the search works. Ideally I would like to see it changing towards these objectives:

I think we should reimplement the search with these objectives in mind:

  • A simpler query format. The current one is undocumented and behaves in an unexpected (in my opinion) way. See "Advanced" search #1218 (comment)
  • Better at detecting DB structure.
  • A clear way to provide your own search if the default is not enough.

Particularly regarding the second point, we may want to lean more on Arel to do the difficult work for us: https://thoughtbot.com/blog/using-arel-to-compose-sql-queries

@pablobm pablobm added search finding things through our models epic labels Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic search finding things through our models
Projects
None yet
Development

No branches or pull requests

1 participant