You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a field in COLLECTION_ATTRIBUTES has no key in ATTRIBUTE_TYPES either because I misspelled it or I forget to add it to ATTRIBUTE_TYPES I will get a undefined method new for nil:NilClass in Page::Base
It would be nicer to see a custom exception Attribute xyz not found in dashboard AbcDashboard
This has already happened multiple times on my first day of using Administrate so I think this is worthwhile to fix.
The text was updated successfully, but these errors were encountered:
Could you provide feedback, please? I wasn't sure how to add a test for that. Any hints would be appreciated.
Also I don't know how Thoughtbot deals with HEREDOCS? Do you use indentation?
@5minpause can you open a PR for that commit, so we can leave comments on it more effectively?
For HEREDOCs, I usually go with this:
string = <<-SOMETHING.strip_heredoc
If you use `<<-` instead of `<<`,
it lets you indent the closing tag.
The `strip_heredoc` removes leading indentation
for the heredoc string.
SOMETHING
If a field in
COLLECTION_ATTRIBUTES
has no key inATTRIBUTE_TYPES
either because I misspelled it or I forget to add it toATTRIBUTE_TYPES
I will get aundefined method new for nil:NilClass
inPage::Base
It would be nicer to see a custom exception
Attribute xyz not found in dashboard AbcDashboard
This has already happened multiple times on my first day of using Administrate so I think this is worthwhile to fix.
The text was updated successfully, but these errors were encountered: