Add rails g ember-cli:heroku
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def bower_path | ||
| @bower_path ||= | ||
| Helpers.which("bower") || | ||
| Rails.root.join("node_modules", ".bin", "bower") |
There was a problem hiding this comment.
Use 2 (not 0) spaces for indenting an expression in an assignment spanning multiple lines.
seanpdoyle
force-pushed
the
sd-heroku
branch
4 times, most recently
from
3cdcb89
to
5e48aef
Compare
| @@ -78,6 +78,10 @@ def initialize(app) | |||
| app_options.fetch(:tee_path){ configuration.tee_path } | |||
| end | |||
|
|
|||
| define_path :bower do | |||
| app_options.fetch(:bower_path){ configuration.bower_path } | |||
seanpdoyle
force-pushed
the
sd-heroku
branch
2 times, most recently
from
9613ae0
to
a43469f
Compare
|
|
||
| namespace "ember-cli:heroku" | ||
|
|
||
| gem "rails_12factor", group: [:staging, :production] |
There was a problem hiding this comment.
This is causing a strange error:
/Users/seanpdoyle/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/bundler-1.10.6/lib/bundler/rubygems_integration.rb:292:in `bloc
k in replace_gem': rails_12factor is not part of the bundle. Add it to Gemfile. (Gem::LoadError)
gem is a generator method, but this looks like it's using the version that found in the Gemfile
seanpdoyle
force-pushed
the
sd-heroku
branch
4 times, most recently
from
6f19fb3
to
e4453e3
Compare
|
|
||
| ```sh | ||
| heroku config:set NPM_CONFIG_PRODUCTION=false | ||
| heroku buildpacks:set https://github.com/heroku/heroku-buildpack-multi |
There was a problem hiding this comment.
From the recent docs it looks like you can just use heroku buildpacks:add and don't need to declare the Multi buildpack anymore.
seanpdoyle
force-pushed
the
sd-heroku
branch
3 times, most recently
from
89bf511
to
b320845
Compare
| @@ -2,6 +2,8 @@ master | |||
| ------ | |||
|
|
|||
| * Drop support for Ruby `< 2.1.0` and Rails `4.0.0, < 3.2.0` | |||
| * Introduce `rails g ember-cli:heroku` generator to setup a project for | |||
There was a problem hiding this comment.
I made this comment and then Github had some saving problems.
How about "to set up a project for Heroku deployment"? ("setup" is a noun, "set up" is a verb)
|
Looks great to me! I'm excited about this gem. :) |
To configure your Ember CLI Rails app to be ready to deploy on Heroku: 1. Run `rails g ember-cli:heroku` generator 1. [Add the NodeJS buildpack][buildpack] and configure NPM to include the `bower` dependency's executable file. ```sh heroku buildpacks:add --index 1 https://github.com/heroku/heroku-buildpack-nodejs heroku config:set NPM_CONFIG_PRODUCTION=false ``` [buildpack]: https://devcenter.heroku.com/articles/using-multiple-buildpacks-for-an-app#adding-a-buildpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To configure your Ember CLI Rails app to be ready to deploy on Heroku:
rails g ember-cli:herokugeneratorbowerdependency's executable file.