Deprecate the :enable initializer option
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
sd-deprecate-enabled
branch
11 times, most recently
from
65c13ac
to
6c329a7
Compare
The `enable` option was meant to provide users with a means of skipping Ember compilation when TDDing API endpoints. This commit removes the option, deferring Ember request detection to the `mount_ember_app` at the routing layer.
seanpdoyle
force-pushed
the
sd-deprecate-enabled
branch
from
6c329a7
to
d7b6fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enableoption was meant to provide users with a means of skippingEmber compilation when TDDing API endpoints.
This commit removes the option, deferring Ember request detection
to the
mount_ember_appat the routing layer.