No longer check dependencies #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
sd-dependencies
branch
3 times, most recently
from
f31fee6
to
3d2af74
Compare
Closes [#262]. Managing user dependencies within app code is more trouble than it's worth. Being explicit about our EmberCLI support in our `README.md` and keeping the addon version in lock-step with the gem will be a better solution long term. Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails [pipes to a file and monitors][error-file], front-end failures will communicated to users through normal Error-raising means. [#262]: #262 [stderr]: ember-cli/ember-cli#5039 [error-file]: #245
seanpdoyle
force-pushed
the
sd-dependencies
branch
from
3d2af74
to
b8a8452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262.
Managing user dependencies within app code is more trouble than it's
worth. Being explicit about our EmberCLI support in our
README.mdandkeeping the addon version in lock-step with the gem will be a better
solution long term.
Since EmberCLI now writes to STDERR, which EmberCLI-Rails
pipes to a file and monitors, front-end failures will
communicated to users through normal Error-raising means.