Patch Rails 5.1 not supporting text option for render anymore #519
Conversation
app/helpers/ember_rails_helper.rb
Outdated
| begin | ||
| render text: template | ||
| rescue ArgumentError | ||
| render body: template |
There was a problem hiding this comment.
Could we simplify this block and use body as the argument no matter what?
There was a problem hiding this comment.
It looks like render accepts an :html option, should we use that instead?
There was a problem hiding this comment.
Sure :html would prob. be better - :body would be the closest equivalent to what :text does/did and I was not sure if the :html option was unwanted in some cases ... For compatibility I chose to have this rescue block - knowing that it's kind of ugly :/
4.0 seems not to support :body and :html options for render. http://guides.rubyonrails.org/v4.0/layouts_and_rendering.html#using-render
There was a problem hiding this comment.
Thanks for clarifying.
This project supports rails>=4.1, so a breaking change in 4.0 is not a show stopper.
…ember_rails_helper
|
@seanpdoyle any blockers to merging this in? Rails 5.1 has hit release candidate and it would be awesome to have a ember-cli-rails release w/ compatibility on day one if possible. |
|
@wireframe CI is failing, but it looks like it might be unrelated. Once it's green, we can merge. |
|
Unfortunately, I've been unable to correct the issues with CI failing. I've tested this change manually and it's good to go, and has been merged in 585cfea. |
Ran into an exception while trying to use this with rails 5.1 - :text option is no longer supported by ActionView:: TemplateRenderer