Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate empty yarn.lock using Yarn on Heroku #540

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Generate empty yarn.lock using Yarn on Heroku #540

merged 1 commit into from
Jul 28, 2017

Conversation

seanpdoyle
Copy link
Contributor

Closes #538.

Generate an empty yarn.lock so that Heroku understands that the
application's deployment target requires yarn.

houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb Outdated

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

@seanpdoyle seanpdoyle mentioned this pull request Jul 14, 2017
Closed
Repository owner deleted a comment from houndci-bot Jul 14, 2017
houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb Outdated

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb Outdated

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb Outdated

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb Outdated

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb Outdated

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

houndci-bot
houndci-bot reviewed Jul 14, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb Outdated

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

houndci-bot
houndci-bot reviewed Jul 28, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

spec/generators/ember/heroku/heroku_generator_spec.rb

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

@seanpdoyle
Generate empty yarn.lock using Yarn on Heroku
ca36543 
Closes [#538].
Related to [#297].

Generate an empty `yarn.lock` so that Heroku understands that the
application's deployment target requires `yarn`.

[#538]: #538
[#297]: #297
@seanpdoyle seanpdoyle merged commit ca36543 into master Jul 28, 2017
houndci-bot
houndci-bot reviewed Jul 28, 2017
View reviewed changes
spec/generators/ember/heroku/heroku_generator_spec.rb

run_generator

expect(destination_root).to have_structure {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesize the param `have_structure {

@seanpdoyle seanpdoyle deleted the generate-yarn-lock branch July 28, 2017 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanpdoyle @houndci-bot