Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew audit #107

Closed
Ashton-W opened this issue Mar 13, 2014 · 2 comments
Closed

brew audit #107

Ashton-W opened this issue Mar 13, 2014 · 2 comments

Comments

@Ashton-W
Copy link

Running brew audit and noticed there are some warnings about adherence to Homebrew house style

> brew audit
liftoff:
 * Use https:// URLs for homepages on GitHub (url is http://github.com/thoughtbot/liftoff).
 * Non-libraries were installed to "/usr/local/Cellar/liftoff/1.0/lib".
Installing non-libraries to "lib" is discouraged.
The offending files are:
  /usr/local/Cellar/liftoff/1.0/lib/liftoff.rb
@gfontenot
Copy link
Member

Oh, thanks. Good info. I'll be sure to fix these for the next release.

gfontenot added a commit that referenced this issue Mar 13, 2014
@gfontenot
Install lib as rubylib
659bbb9 
Homebrew happily symlinks any folder called lib into /usr/local/lib/ and
then yells at you about it like it's _your_ fault.

The easiest way around this is to install the lib directory with a
different name.

Also, extract the crazy Xcodeproj native extension building into a new
method for clarity

Fixes #107
@gfontenot
Copy link
Member

I've fixed these issues in 2ddce12

Thanks for the report! Turns out Homebrew does some wacky shit automatically if you've got a directory named lib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfontenot @Ashton-W