OTHER_LDFLAGS setting is overridden with a blank value

[frosty]

When creating a new project with Liftoff that uses Cocoapods, the pod installation output warns that the OTHER_LDFLAGS setting has been overridden:

[!] The target `ExampleProject [Release]` overrides the `OTHER_LDFLAGS` build setting defined in `Pods/Pods.xcconfig'.
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

[!] The target `ExampleProject [Release - Debug]` overrides the `OTHER_LDFLAGS` build setting defined in `Pods/Pods.xcconfig'.
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

On opening the newly-generated project, I can confirm that the Other Linker Flags setting is marked as having a custom value in Build Settings - and is empty.

I would expect a fresh project to have no custom value set for this property, so that these warnings are not generated by Cocoapods. Either that, or Liftoff should add the $(inherited) flag. I'm not entirely sure whether this is a Liftoff issue, an Xcodeproj issue, a Cocoapods issue, or something else?

I can't see any mention of OTHER_LDFLAGS within the Liftoff project itself.

[frosty]

I've done a bit of investigation and it looks like the origin of this issue is in Xcodeproj. The project contains a list of COMMON_BUILD_SETTINGS, which includes an empty value for OTHER_LDFLAGS (https://github.com/CocoaPods/Xcodeproj/blob/5bee3d3b08e7f8de793e7bda3851ed5f47496400/lib/xcodeproj/constants.rb#L122) which results in an empty overridden build setting if no other values are set.

Presumably I should raise this issue over there? Otherwise, I guess Liftoff should set a value here like $(inherited).

[gfontenot]

Thanks for this. I'll open a PR on Xcodeproj as well to try and fix this, but for now, I'm just going to remove it manually on our end.