Centralize deployment target #123
Conversation
| target.build_configurations.each do |configuration| | ||
| configuration.build_settings.delete('OTHER_LDFLAGS') | ||
| configuration.build_settings.delete('IPHONEOS_DEPLOYMENT_TARGET') |
There was a problem hiding this comment.
why would you need to delete this setting, only to set it later? (line 75)
There was a problem hiding this comment.
This is deleting the default that Xcodeproj sets at the target level (4.3 by default). When we set it later, we're setting it at the project level instead.
|
👍 the target should default to the latest base version (currently 7.0) ... changes for that can be done once the project is opened IMO |
| @@ -3,6 +3,8 @@ class ProjectConfiguration | |||
| attr_accessor :project_name, :company, :prefix, :configure_git, :warnings_as_errors, :install_todo_script, :enable_static_analyzer, :indentation_level, :warnings, :application_target_groups, :unit_test_target_groups, :use_cocoapods | |||
| attr_writer :author, :company_identifier | |||
|
|
|||
| LATEST_IOS = 7.0 | |||
There was a problem hiding this comment.
According to our guides:
Order model contents: constants, macros, public methods, private methods
While this was in the [rails](Order model contents: constants, macros, public methods, private methods) section, it probably applies to ruby as well
I would put the constant right below the class name, above the attr_accessor macros
- Set the deployment target at the project level instead of at the target level. This mimics the behavior of Xcode. - Configure the deployment target with ProjectConfiguration. - Use the deployment target information to populate values inside templates.
|
👍 |
target level. This mimics the behavior of Xcode.
templates.