Add the ability to customize/disable Xcode command #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +42,10 @@ def global_options | |||
| @options[:configure_git] = configure_git | |||
| end | |||
|
|
|||
| opts.on('--no-open', "Don't open Xcode after generation") do |open_xcode| | |||
There was a problem hiding this comment.
Is the block parameter necessary or could it be left out?
There was a problem hiding this comment.
Honestly don't know. Let's find out!
There was a problem hiding this comment.
Looks like I don't need it. I'll remove it.
|
LGTM 👍 |
|
👍 |
gfontenot
force-pushed
the
gf-open-command
branch
from
f2f7f19
to
ec844bb
Compare
This lets users override the command to open the project. Possible use cases: - Open with a beta version of Xcode - Open with AppCode - Open the directory with Vim - Set the config to `false` to disable automatic opening.
This flag will disable the automatic project opening after generation behavior.
gfontenot
force-pushed
the
gf-open-command
branch
from
ec844bb
to
57296f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--no-opencli flag as well as anxcode_commandkey tothe liftoffrc.
--no-openwill let the user completely disable liftoff's ability toautomatically open Xcode after successfully generating a project
xcode_commandlets the user customize the command used to open Xcode.The contents of this key are executed arbitrarily, so allow the user to
customize their development process by using beta versions of Xcode,
AppCode, Vim, Emacs, etc instead of using the default version of Xcode.
Setting this key to
falsewill disable this behavior completely.Fixes #166