Allow the user to specify a path from the CLI (#77) #209
Conversation
The CLI command now optionally takes a path to use as destination for the project. If now path is given by the user, the default of the project name is used.
|
Ignore those Hound warnings. I'll check this out in the AM.
|
| @@ -18,7 +18,8 @@ def parse_command_line_options | |||
|
|
|||
| def global_options | |||
| OptionParser.new do |opts| | |||
| opts.banner = 'usage: liftoff [-v | --version] [-h | --help] [config options]' | |||
| opts.banner = 'usage: liftoff [-v | --version] [-h | --help] ' \ | |||
There was a problem hiding this comment.
Don't worry about breaking this line up just to appease Hound.
| @@ -11,7 +11,7 @@ def liftoff(options) | |||
| validate_template | |||
| fetch_options | |||
|
|
|||
| file_manager.create_project_dir(@config.project_name) do | |||
| file_manager.create_project_dir(path ? path : @config.project_name) do | |||
There was a problem hiding this comment.
Having this logic here feels like a smell to me. I think it would be best to add a path attribute to the project configuration, and put this logic there. The implementation would be fairly trivial:
def path
@path || project_name
endThis would also let us add a test around the logic.
|
Sorry for flaking on this for so long. I really like how simple this ended up being. As I noted, I think it would be best to move the path into the project configuration itself. That seems like it would be the cleanest way to handle it. |
|
I need to turn off Hound since they changed their defaults away from our style. Ignore all of those. |
| @@ -7,7 +7,7 @@ def initialize(argv) | |||
|
|
|||
| def run | |||
| parse_command_line_options | |||
| LaunchPad.new.liftoff @options | |||
| LaunchPad.new.liftoff @options, @argv.first | |||
There was a problem hiding this comment.
If you set this at the very bottom of the option parsing, you'll be able to remove a lot of the logic around adding this to the configuration. Should be as simple as @options[:path] = @argv.first
There was a problem hiding this comment.
I was reluctant about that. It feels weird because it could mean that you can preset the path from the config file.
There was a problem hiding this comment.
Sure, but most people won't. The path passed on the command line will take precedence anyway, so I don't think it's that big of a deal. I'm more interested in simplifying this code path than preventing a weird customization.
| @@ -109,6 +109,28 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe '#path' do | |||
| context 'when the path is not given in the constructor' do | |||
| it 'return the project name' do | |||
|
@gfontenot Beat you to it. I totally forgot about the test after changing the logic. Sorry about that! |
|
Nice! Reworded the tests just a bit and merged as cfd7bf6 Thanks! |
The CLI command now optionally takes a path to use as destination for
the project. If now path is given by the user, the default of the
project name is used.