Improve test target detection in xcodeproj_helper #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have customizable test target names, we can use that to detect test targets instead of just looking for the suffix "Tests".
| @@ -86,11 +90,11 @@ def test_target | |||
| end | |||
|
|
|||
| def application_targets | |||
| all_targets.reject { |t| t.name.end_with?('Tests') } | |||
| all_targets.reject { |t| t.name.end_with?(@test_target_name) } | |||
There was a problem hiding this comment.
Thoughts on t.name == @test_target_name?
There was a problem hiding this comment.
oh, yeah, that makes more sense
|
Would you be able to add a test covering this? |
|
I don't think so. This is so deep in the dumpster fire that is |
|
If you have ideas on how to test this though, I'm all ears. |
|
@gfontenot For a test I'd probably stub out the xcode_project method to return a stub of one and then test the 2 methods you modified work as expected. |
|
that sounds like so much work fine |
|
carry on. private methods, le sigh. |
|
Opened #254 to try and fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have customizable test target names, we can use that to
detect test targets instead of just looking for the suffix "Tests".
Fixes #218 (finally)