Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_value matcher throws error when is used without the for #706

Closed
maurogeorge opened this issue Apr 22, 2015 · 2 comments
Closed

allow_value matcher throws error when is used without the for #706

maurogeorge opened this issue Apr 22, 2015 · 2 comments
Labels

Comments

@maurogeorge
Copy link
Contributor

Using the allow_value matcher on 2.7.0/2.8.0 displays the following error:

Failure/Error: it { is_expected.to allow_value('jon@example.com', 'jon+1@example.com.br') }
     NoMethodError:
       undefined method `=' for #<ContactForm:0x007fc408bcbd48>

This occurs when the for method has not been passed to the allow_value, eg.

it { is_expected.to allow_value('jon@example.com', 'jon+1@example.com.br') }
@mcmire mcmire added the UX label Apr 23, 2015
@mcmire mcmire added this to the 3.0.0 milestone Apr 23, 2015
@mcmire
Copy link
Collaborator

mcmire commented Apr 23, 2015

Yup, definitely a long standing but known issue. I'm working on refactoring the tests as a part of switching allow_value with allow_values for #692, and I'll make this change as a part of that.

@mcmire mcmire modified the milestones: 3.1.0, 3.0.0 Jun 1, 2015
@mcmire mcmire removed this from the 3.x milestone Feb 18, 2019
@mcmire
Copy link
Collaborator

mcmire commented May 6, 2020

Hey folks. In an effort to lighten our load as maintainers and be able to serve you better in the future, the shoulda-matchers team is working on cleaning out the cobwebs in this repo by pruning the backlog. As there are few of us, there are a lot of items that will simply never earn our attention in a reasonable time frame, and rather than giving you an empty promise, we think it makes more sense to focus on more recent issues. That means, unfortunately, that we must close this issue.

Don't take this the wrong way: our aim is not to diminish the effort people have made or dismiss problems that have been raised. If you feel that we should reopen this issue, then please let us know so that we can reprioritize it. Thanks!

@mcmire mcmire closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants