weird error information

[lidaobing]

  1) MaterialOptionImage validations 
     Failure/Error: it { should validate_uniqueness_of(:material_image_id).scoped_to(:material_option_id) }
       Expected errors to include "has already been taken" when material_image_id is set to 1, got errors: ["material_image_id has already been taken (1)"] (with different value of material_option_id)
     # ./spec/models/material_option_image_spec.rb:16:in `block (3 levels) in <top (required)>'

for the error information, I think this test should be passed, but it does not pass.

[gabebw]

Do you have internationalized errors? Have you ever added anything in config/locales?

[lidaobing]

it's the same error after I remove config/locales/en.yml

  1) MaterialOptionImage validations 
     Failure/Error: it { should validate_uniqueness_of(:material_image_id).scoped_to(:material_option_id) }
       Expected errors to include "has already been taken" when material_image_id is set to 1, got errors: ["material_image_id has already been taken (1)"] (with different value of material_option_id)
     # ./spec/models/material_option_image_spec.rb:16:in `block (3 levels) in <top (required)>'

[gabebw]

If you do a test without using shoulda-matchers, does it pass?

Try creating a record, then creating a second record that violates the uniqueness constraint and checking object.errors.full_messages on the second one. Do the expected errors show up?

[lidaobing]

[13] pry(main)> MaterialOptionImage.last.dup.tap(&:valid?).errors.full_messages
  MaterialOptionImage Load (0.3ms)  SELECT `material_option_images`.* FROM `material_option_images` ORDER BY `material_option_images`.`id` DESC LIMIT 1
  MaterialOption Load (0.3ms)  SELECT `material_options`.* FROM `material_options` WHERE `material_options`.`id` = 8 LIMIT 1
  MaterialImage Load (0.3ms)  SELECT `images`.* FROM `images` WHERE `images`.`type` IN ('MaterialImage') AND `images`.`id` = 255 LIMIT 1
  MaterialOptionImage Exists (0.2ms)  SELECT 1 AS one FROM `material_option_images` WHERE (`material_option_images`.`material_image_id` = BINARY 255 AND `material_option_images`.`material_option_id` = 8) LIMIT 1
=> ["Material image has already been taken"]

[xaethos]

Just looking at the error messages it seems clear that the matcher is looking for the short message in the object.errors.full_messages array. Shouldn't the matcher be looking instead in object.errors[:material_image_id]?

[mxie]

Could someone put together a barebones repo that would reproduce this issue? It will make it easier for us to investigate. Thanks!

[ivanvc]

I have exactly this same issue, I'm not sure if it's worth setting up a barebones repo, since my app has this matcher called in several places and it's just failing in one place. This is what I'm getting:

  1) Hourly
     Failure/Error: it { should validate_uniqueness_of(:timestamp).scoped_to(:source_id) }
       Expected errors to include "has already been taken" when timestamp is set to Fri, 26 Apr 2013 18:00:00 UTC +00:00, got errors: ["timestamp has already been taken (Fri, 26 Apr 2013 18:00:00 UTC +00:00)"] (with different value of source_id)

Hourly has the following validation:

class Hourly < ActiveRecord::Base
  ...
  validates :timestamp,
    uniqueness: { scope: :source_id },
    presence: true
  ...
end

I've tried removing the presence validation, and deleting locale files with no luck . As I mentioned, there are other instances in the app where this matcher is working. Just updated to shoulda 3.4.0, and still have the same problem. Not sure what else can I add to this issue.

[drapergeek]

Please try using verison 2.1.0 and if this is still a failure please let us know. Thanks.

[opsdeveloper]

yes, it's still there with 2.1.0

[ivanvc]

As @opsdeveloper said, it's still present...

[mcmire]

Hey @ivanvc, I am not able to reproduce this with a fresh Rails 3 app using your example. Here is the test app that I set up -- is this what you are doing?

[ivanvc]

Hi @mcmire, I know it's odd, but as said before in some models that problem is occurring, and in others not. This weekend will try to strip down my application in order to isolate the problem, and that would be a starting point.

[ivanvc]

Hi @mcmire, I've forked your repo (http://github.com/ivanvc/sm-207-test-app), and added some code in order to reproduce it. I've found that in my case the problem appears to be somehow related, to have some nested parent models. Hope it helps to fix it.

[allenwyma]

Also having this issue:

Expected errors to include "has already been taken" when date is set to Tue, 14 May 2013, 
got errors: ["organizable can't be blank (nil)", "organizable can't be blank (nil)", "note can't be blank (nil)", 
"note can't be blank (nil)", "date has already been taken (Tue, 14 May 2013)", 
"date has already been taken (Tue, 14 May 2013)"] (with different value of organizable_id)

But I'm scoping to a polymorphic relationship with 2 columns. Or should I use something like subject.organizable to set it's polymorphic attribute to the previously created one?

[ivanvc]

After some investigation, I've found that the problem (that was manifesting in my fork of sm-207-test-app), relates to a comment from validate_uniqueness_of_matcher.rb. And the problem is that when setting the new scoped value, it's already taken by another record. That makes validate_after_scope_change? to return false, so the test fails.

I've fixed this issue, but not completely sure that is the best approach. Anyway, I'm creating a pull request right now, so you can review it.

[mcmire]

@ivanvc Ahhh... right. That makes sense. Thanks, I'll take a look.