Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "Empty Component" thingy #2

Closed
cburgdorf opened this issue Sep 13, 2014 · 5 comments · Fixed by #40
Closed

Implement "Empty Component" thingy #2

cburgdorf opened this issue Sep 13, 2014 · 5 comments · Fixed by #40
Labels
comp: lib effort1: easy (hour) P2: required type: feature

Comments

@cburgdorf
Copy link
Contributor

https://github.com/ajoslin/conventional-changelog/blob/master/lib/writer.js#L82
@vyp
Copy link

vyp commented Apr 23, 2015

Dead link. (Because writer.js renamed to Writer.js I presume.) I think you meant https://github.com/ajoslin/conventional-changelog/blob/37f5561553c30d8f0f2c949502ea278da64949cd/lib/writer.js#L82.

(Also, for the current the current: https://github.com/ajoslin/conventional-changelog/blob/be0808e70890abc344fa3250b35d6014fe75aa92/lib/Writer.js#L144.)

@kbknapp
Copy link
Member

kbknapp commented May 19, 2015

I'm not a JS guy...so what does this actually do? Is it simply allowing you do a feat(): some message? If so, I may be able to try this out later this week.

@cburgdorf
Copy link
Contributor Author

Exactly, and I think it's also allowed to shortcut that to feat: some message

@kbknapp
Copy link
Member

kbknapp commented May 20, 2015

👍

@orclev
Copy link
Contributor

orclev commented May 21, 2015

This would be a nice feature to have.

kbknapp added a commit that referenced this issue May 21, 2015
@kbknapp
feat(sections): allows users to use empty components in commit subjects
71b32ee 
Users can now use "feat: some message" or "feat(): some message" style
commit subjects

Closes #2
@kbknapp kbknapp mentioned this issue May 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: lib effort1: easy (hour) P2: required type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sections): allows users to use empty components in commit subjects clog-tool/clog-cli
5 participants
@orclev @0x-r4bbit @cburgdorf @vyp @kbknapp